gpsbabel.git
7 years agoa few more const_cast eliminations.
tsteven4 [Sun, 1 Jul 2018 19:23:38 +0000 (13:23 -0600)]
a few more const_cast eliminations.

7 years agopreserve const in garmin_txt.
tsteven4 [Sun, 1 Jul 2018 18:36:47 +0000 (12:36 -0600)]
preserve const in garmin_txt.

7 years agoremove more unnecessary const_casting.
tsteven4 [Sun, 1 Jul 2018 15:26:10 +0000 (09:26 -0600)]
remove more unnecessary const_casting.

7 years agoget rid of more unneeded const_cast.
tsteven4 [Sun, 1 Jul 2018 14:45:33 +0000 (08:45 -0600)]
get rid of more unneeded const_cast.

7 years agoget MSVC happy with util const_cast changes.
tsteven4 [Sun, 1 Jul 2018 12:36:11 +0000 (06:36 -0600)]
get MSVC happy with util const_cast changes.

7 years agoremove unnecesary const_cast in util.cc.
tsteven4 [Sun, 1 Jul 2018 12:26:42 +0000 (06:26 -0600)]
remove unnecesary const_cast in util.cc.

7 years agoeliminate uneccesary const_cast in osm format.
tsteven4 [Sat, 30 Jun 2018 21:17:12 +0000 (15:17 -0600)]
eliminate uneccesary const_cast in osm format.

7 years agoMerge remote-tracking branch 'origin/master' into constcast
tsteven4 [Sat, 30 Jun 2018 21:10:10 +0000 (15:10 -0600)]
Merge remote-tracking branch 'origin/master' into constcast

7 years agouse member brace initializes and default constructors. (#214)
tsteven4 [Sat, 30 Jun 2018 21:05:55 +0000 (15:05 -0600)]
use member brace initializes and default constructors. (#214)

7 years agoremove more unnecessary casting away of const.
tsteven4 [Sat, 30 Jun 2018 14:19:23 +0000 (08:19 -0600)]
remove more unnecessary casting away of const.

7 years agoremove unnecessary casting away of const.
tsteven4 [Sat, 30 Jun 2018 13:34:15 +0000 (07:34 -0600)]
remove unnecessary casting away of const.

7 years agoclang tidy uses const_cast.
tsteven4 [Thu, 28 Jun 2018 14:04:06 +0000 (08:04 -0600)]
clang tidy uses const_cast.

This was from the google-readability-casting check,
but only Message: C-style casts are discouraged; use const_cast
were accepted.

7 years agoeliminate superfluous casting "redundant cast to the same type" (#212)
tsteven4 [Thu, 28 Jun 2018 13:25:44 +0000 (07:25 -0600)]
eliminate superfluous casting "redundant cast to the same type" (#212)

* eliminate superfluous casting "redundant cast to the same type"

this was based on clang-tidy google-readability-casting check,
but only for the Message redundant cast to the same type.
Some hand manipulation of literals was done before clang-tidy.
Some fixes were rejected for portability.

* eliminate a couple casts of integer literals to double.

* a few more casts of integer literals.

7 years agoCreate a filter base class and make all our filters derived classes of this base...
tsteven4 [Wed, 27 Jun 2018 21:36:08 +0000 (15:36 -0600)]
Create a filter base class and make all our filters derived classes of this base class. (#190)

7 years agoclang-tidy fix modernize-deprecated-headers on windows files. (#211)
tsteven4 [Wed, 27 Jun 2018 00:38:44 +0000 (18:38 -0600)]
clang-tidy fix modernize-deprecated-headers on windows files. (#211)

7 years agofix clang-tidy found readability-static-accessed-through-instance. (#210)
tsteven4 [Wed, 27 Jun 2018 00:25:48 +0000 (18:25 -0600)]
fix clang-tidy found readability-static-accessed-through-instance. (#210)

7 years agoclang tidy optimizes to use parameter passing by const reference. (#209)
tsteven4 [Tue, 26 Jun 2018 22:33:26 +0000 (16:33 -0600)]
clang tidy optimizes to use parameter passing by const reference. (#209)

RUN_CLANG_TIDY_FLAGS="-header-filter=.*\\\.h -checks=-*,performance-unnecessary-value-param -fix

The suggestion "parameter '*' is passed by value and only copied once; consider moving
it to avoid unnecessary copies" was not accepted.

The suggestion "the const qualified parameter '*' is copied for each invocation;
consider making it a reference" was accepted.

The suggestion "the parameter '*' is copied for each invocation but only used as a const
reference; consider making it a const reference" was accepted.

7 years agofix missing-field-initializers clang diagnostic. (#207)
tsteven4 [Tue, 26 Jun 2018 18:01:42 +0000 (12:01 -0600)]
fix missing-field-initializers clang diagnostic. (#207)

7 years agouse c++11 noreturn attribute specifier instead of compiler specific attributes. ...
tsteven4 [Sun, 24 Jun 2018 23:38:45 +0000 (17:38 -0600)]
use c++11 noreturn attribute specifier instead of compiler specific attributes. (#206)

This should work for all compilers, and certainly helps out MSVC code analysis.

7 years agoadd version check to GPSBabel.pro, fix header dependencies. (#205)
tsteven4 [Sat, 23 Jun 2018 19:27:21 +0000 (13:27 -0600)]
add version check to GPSBabel.pro, fix header dependencies. (#205)

7 years agocorrect header file list in GPSBabel.pro, and a warning fix. (#203)
tsteven4 [Thu, 21 Jun 2018 20:13:39 +0000 (14:13 -0600)]
correct header file list in GPSBabel.pro, and a warning fix. (#203)

C4146: unary minus operator applied to unsigned type, result still unsigned

7 years agoMSVC warning cleanup (#202)
tsteven4 [Wed, 20 Jun 2018 22:51:29 +0000 (16:51 -0600)]
MSVC warning cleanup (#202)

7 years agoenhance track filter test. (#201)
tsteven4 [Mon, 18 Jun 2018 23:52:33 +0000 (17:52 -0600)]
enhance track filter test. (#201)

7 years agocleanup defs.h orgainizing route and waypt elemements. (#200)
tsteven4 [Mon, 18 Jun 2018 23:07:37 +0000 (17:07 -0600)]
cleanup defs.h orgainizing route and waypt elemements. (#200)

The following prototypes were deleted, they had no definitions:
waypt_free
waypt_dupe
waypt_new
route_add
waypt_alloc_gc_data
waypt_empty_gc_data

The following functions were never used, and they had no prototypes:
void routes_to_tracks();
void tracks_to_routes();

The following function had a repeated prototype:
route_flush

The following function is missing a prototype but is explictly listed by the using file:
update_common_traits

In addition to resolving the above issues, some sections of defs.h
were moved based on if they came from waypt.cc or route.cc,
when they were required, and grouping of similar elements.

7 years agoimprove travis docker script. (#199)
tsteven4 [Mon, 18 Jun 2018 18:33:57 +0000 (12:33 -0600)]
improve travis docker script. (#199)

7 years agoupdate Dockerfile to reduce image size. (#198)
tsteven4 [Sun, 17 Jun 2018 22:27:00 +0000 (16:27 -0600)]
update Dockerfile to reduce image size. (#198)

7 years agocleanup whining about validate filter, and add test. (#197)
tsteven4 [Sun, 17 Jun 2018 16:57:09 +0000 (10:57 -0600)]
cleanup whining about validate filter, and add test.  (#197)

7 years agoCI debug, codacy excludes, obsolete file deletion. (#196)
tsteven4 [Sun, 17 Jun 2018 14:41:36 +0000 (08:41 -0600)]
CI debug, codacy excludes, obsolete file deletion. (#196)

7 years agogenerate codacy coverage report on travis (#195)
tsteven4 [Sun, 17 Jun 2018 03:46:46 +0000 (21:46 -0600)]
generate codacy coverage report on travis (#195)

7 years agomore excludes for codacity. (#194)
tsteven4 [Sat, 16 Jun 2018 21:01:25 +0000 (15:01 -0600)]
more excludes for codacity. (#194)

7 years agoDelete nmea_cc
Robert Lipe [Sat, 16 Jun 2018 20:02:44 +0000 (15:02 -0500)]
Delete nmea_cc

Scratch work file that was accidentally committed.

7 years agoCheck in codacy config file
Robert Lipe [Sat, 16 Jun 2018 19:57:38 +0000 (14:57 -0500)]
Check in codacy config file

Ignore deprecated and third party code.

7 years agocleanups for codacy warnings. (#192)
tsteven4 [Thu, 14 Jun 2018 22:32:56 +0000 (16:32 -0600)]
cleanups for codacy warnings. (#192)

take advantage of C++11 delete to block a default operator, and move a bunch of loop index declarations to the loop.

7 years agoreduce docker layer size in an attempt to workaround network problems. (#191)
tsteven4 [Mon, 11 Jun 2018 21:55:18 +0000 (15:55 -0600)]
reduce docker layer size in an attempt to workaround network problems. (#191)

7 years agoLimit scope of variables and functions that are not meant to be shared. (#188)
tsteven4 [Wed, 6 Jun 2018 20:23:52 +0000 (14:23 -0600)]
Limit scope of variables and functions that are not meant to be shared. (#188)

restrict unshared variables and functions to file scope.

7 years agorestore fiddling with -e in kml test. (#189)
tsteven4 [Tue, 5 Jun 2018 23:47:23 +0000 (17:47 -0600)]
restore fiddling with -e in kml test. (#189)

this allows subsequent test errors to be counted.

7 years agoMerge pull request #187 from tsteven4/style_nullptr
tsteven4 [Tue, 5 Jun 2018 05:58:57 +0000 (23:58 -0600)]
Merge pull request #187 from tsteven4/style_nullptr

catch mkstyle.sh up with nullptr.

7 years agocatch mkstyle.sh up with nullptr.
tsteven4 [Tue, 5 Jun 2018 05:46:26 +0000 (23:46 -0600)]
catch mkstyle.sh up with nullptr.

7 years agoMerge pull request #186 from tsteven4/tidyup
tsteven4 [Sun, 3 Jun 2018 13:09:35 +0000 (07:09 -0600)]
Merge pull request #186 from tsteven4/tidyup

Modernize with clang-tidy

7 years agoclang-tidy add override specifier.
tsteven4 [Fri, 1 Jun 2018 15:35:44 +0000 (09:35 -0600)]
clang-tidy add override specifier.

-header-filter=.*\\.h -checks=-*,modernize-use-override -fix

7 years agoclang-tidy replaces C standard library headers with their C++ alternatives.
tsteven4 [Fri, 1 Jun 2018 15:34:30 +0000 (09:34 -0600)]
clang-tidy replaces C standard library headers with their C++ alternatives.

-header-filter=.*\\.h -checks=-*,modernize-deprecated-headers -fix

7 years agoclang-tidy replaces integer literals that are cast to bool.
tsteven4 [Fri, 1 Jun 2018 15:33:13 +0000 (09:33 -0600)]
clang-tidy replaces integer literals that are cast to bool.

-header-filter=.*\\.h -checks=-*,modernize-use-bool-literals -fix

7 years agouse clang-tidy to convert the usage of null pointer constants to use the new C++11...
tsteven4 [Fri, 1 Jun 2018 15:31:44 +0000 (09:31 -0600)]
use clang-tidy to convert the usage of null pointer constants to use the new C++11 nullptr keyword.

-header-filter=.*\\.h -checks=-*,modernize-use-nullptr -fix

7 years agoadd make targets to use clang-tidy.
tsteven4 [Fri, 1 Jun 2018 15:26:51 +0000 (09:26 -0600)]
add make targets to use clang-tidy.

7 years agomake use of QStringLiteral with QXmlStreamWriter. (#153)
tsteven4 [Tue, 29 May 2018 15:35:45 +0000 (09:35 -0600)]
make use of QStringLiteral with QXmlStreamWriter. (#153)

7 years agocorrect spelling in document. (#184)
tsteven4 [Mon, 28 May 2018 20:29:54 +0000 (14:29 -0600)]
correct spelling in document. (#184)

7 years agofix link to build log in continuous windows release.
tsteven4 [Sun, 27 May 2018 16:37:07 +0000 (10:37 -0600)]
fix link to build log in continuous windows release.

7 years agoupdate appveyor token instructions. (#183)
tsteven4 [Sun, 27 May 2018 15:32:45 +0000 (09:32 -0600)]
update appveyor token instructions. (#183)

7 years agobug fixes and improvements for uploadtool. (#182)
tsteven4 [Sun, 27 May 2018 14:10:07 +0000 (08:10 -0600)]
bug fixes and improvements for uploadtool. (#182)

* fix body of appveyor uploads.

* give detailed instructions on appveyor upload when GITHUB_TOKEN missing.

* pick up upstream changes to upload.sh.

7 years agoUse date instead of travis/appveyor build number in pre-release names. (#180)
tsteven4 [Tue, 22 May 2018 15:13:05 +0000 (09:13 -0600)]
Use date instead of travis/appveyor build number in pre-release names. (#180)

7 years agotoken massage for appveyor.
tsteven4 [Tue, 22 May 2018 00:48:45 +0000 (18:48 -0600)]
token massage for appveyor.

7 years agofix permissions on extract-qt-installer.
tsteven4 [Tue, 22 May 2018 00:10:45 +0000 (18:10 -0600)]
fix permissions on extract-qt-installer.

7 years agoAdd mac build to travis CI (#179)
tsteven4 [Mon, 21 May 2018 22:39:44 +0000 (16:39 -0600)]
Add mac build to travis CI (#179)

Add mac build to travis CI.
Deploy mac dmg to github releases from travis.
Deploy windows installer to github releases from appveyor.

7 years agoRevert "add creation of appimage."
tsteven4 [Fri, 18 May 2018 21:37:45 +0000 (15:37 -0600)]
Revert "add creation of appimage."

This reverts commit 46f8c773de64761cbde22adb078a26b55e41db2e.

7 years agoRevert "fix packages for travis."
tsteven4 [Fri, 18 May 2018 21:37:43 +0000 (15:37 -0600)]
Revert "fix packages for travis."

This reverts commit 807e853e62d2252a3a66e6b5a9fba647f88e5c3c.

7 years agoRevert "fix travis"
tsteven4 [Fri, 18 May 2018 21:37:42 +0000 (15:37 -0600)]
Revert "fix travis"

This reverts commit 50353d5c57d3a0d4ad1dcaf301354a2675893b61.

7 years agoRevert "fix travis packages, rpath."
tsteven4 [Fri, 18 May 2018 21:37:41 +0000 (15:37 -0600)]
Revert "fix travis packages, rpath."

This reverts commit 16d14a9d462de3983232d8c8d7cd8744387a9488.

7 years agoRevert "fix travis builds"
tsteven4 [Fri, 18 May 2018 21:37:38 +0000 (15:37 -0600)]
Revert "fix travis builds"

This reverts commit 3e5d604ad38573a755d5c2fdf1d9593dc6a76d1d.

7 years agoRevert "have travis avoid ppa environment script."
tsteven4 [Fri, 18 May 2018 21:37:33 +0000 (15:37 -0600)]
Revert "have travis avoid ppa environment script."

This reverts commit f74c139d26efadfa929bcaca1aea5985fa819711.

7 years agoRevert "fix up travis LDFLAGS."
tsteven4 [Fri, 18 May 2018 21:37:14 +0000 (15:37 -0600)]
Revert "fix up travis LDFLAGS."

This reverts commit 8229a81fa41bcccb5db5e1ffba10c2975ee750ed.

7 years agoMerge pull request #176 from tsteven4/appv
tsteven4 [Fri, 18 May 2018 13:14:19 +0000 (07:14 -0600)]
Merge pull request #176 from tsteven4/appv

Drop appveyor Qt 5.7 build, they dropped Qt 5.7 with MSVC 2015.

7 years agodrop appveyor Qt 5.7 build.
tsteven4 [Fri, 18 May 2018 12:49:58 +0000 (06:49 -0600)]
drop appveyor Qt 5.7 build.

7 years agofix up travis LDFLAGS.
tsteven4 [Wed, 16 May 2018 03:04:22 +0000 (21:04 -0600)]
fix up travis LDFLAGS.

7 years agohave travis avoid ppa environment script.
tsteven4 [Wed, 16 May 2018 02:53:46 +0000 (20:53 -0600)]
have travis avoid ppa environment script.

7 years agofix travis builds
tsteven4 [Wed, 16 May 2018 02:13:07 +0000 (20:13 -0600)]
fix travis builds

7 years agofix travis packages, rpath.
tsteven4 [Wed, 16 May 2018 01:32:50 +0000 (19:32 -0600)]
fix travis packages, rpath.

7 years agofix travis
tsteven4 [Wed, 16 May 2018 01:05:28 +0000 (19:05 -0600)]
fix travis

7 years agofix packages for travis.
tsteven4 [Wed, 16 May 2018 01:00:27 +0000 (19:00 -0600)]
fix packages for travis.

7 years agoadd creation of appimage.
tsteven4 [Wed, 16 May 2018 00:50:22 +0000 (00:50 +0000)]
add creation of appimage.

7 years agoMerge pull request #175 from tsteven4/qtpro
tsteven4 [Sun, 13 May 2018 03:23:04 +0000 (21:23 -0600)]
Merge pull request #175 from tsteven4/qtpro

add config tests in GPSBabel.pro.

7 years agoadd config tests in GPSBabel.pro.
tsteven4 [Sat, 12 May 2018 16:54:02 +0000 (10:54 -0600)]
add config tests in GPSBabel.pro.
specifically, we look for stdarg.h and unistd.h for zlib.

7 years agoMerge pull request #174 from gpsbabel/main
tsteven4 [Sun, 6 May 2018 22:30:53 +0000 (16:30 -0600)]
Merge pull request #174 from gpsbabel/main

fix segfault in main and provide more debug info.

7 years agofix segfault in main and provide more debug info.
tsteven4 [Sun, 6 May 2018 21:40:10 +0000 (15:40 -0600)]
fix segfault in main and provide more debug info.
previously "gpsbabel -D" would segfault.
now when using -D Qt version and locale info is printed.

7 years agoupdate gperf usage for C++. (#172)
tsteven4 [Wed, 2 May 2018 21:45:40 +0000 (15:45 -0600)]
update gperf usage for C++. (#172)

this resolves clang 6.0.0 warnings:
warning: 'register' storage class specifier is deprecated and incompatible with C++17 [-Wdeprecated-register]
in_word_set(register const char* str, register unsigned int len);

7 years agoremove vestiges of obsolete options -N, -c, -l. (#171)
tsteven4 [Wed, 2 May 2018 15:02:17 +0000 (09:02 -0600)]
remove vestiges of obsolete options -N, -c, -l. (#171)

7 years agoMerge pull request #168 from gpsbabel/robertlipe-fix-unistd-warning
GPSBabel [Mon, 30 Apr 2018 16:11:29 +0000 (11:11 -0500)]
Merge pull request #168 from gpsbabel/robertlipe-fix-unistd-warning

Fix warning in .Pro build by forcing HAVE_UNISTD

7 years agoFix warning in .Pro build by forcing HAVE_UNISTD
Robert Lipe [Mon, 30 Apr 2018 06:12:35 +0000 (01:12 -0500)]
Fix warning in .Pro build by forcing HAVE_UNISTD

I'm not sure if it's new in Qt 5.9, but it's trivial (I think) to fix and harmless. When building files like gzread and gzwrite, MacOS would complain that we were missing declarations to extremely well known system functions (write, close, read, seek, ...) Those live in <unistd.h>, so we nudge the Makefile generator to trigger its inclusion for MacOS and Linux.

7 years agoMerge pull request #167 from tsteven4/ci_with_new_qt
tsteven4 [Sun, 29 Apr 2018 21:26:52 +0000 (15:26 -0600)]
Merge pull request #167 from tsteven4/ci_with_new_qt

Move Qt floor to 5.7

7 years agofix version check comment in c++ files.
tsteven4 [Sun, 29 Apr 2018 20:54:21 +0000 (14:54 -0600)]
fix version check comment in c++ files.

7 years agosyncrhonize config and run time version checks.
tsteven4 [Sun, 29 Apr 2018 20:50:36 +0000 (14:50 -0600)]
syncrhonize config and run time version checks.

7 years agoadd Dockerfile used to build travis test image.
tsteven4 [Sat, 28 Apr 2018 22:02:50 +0000 (16:02 -0600)]
add Dockerfile used to build travis test image.

7 years agoenforce minimum Qt version in configure.
tsteven4 [Sat, 28 Apr 2018 21:35:26 +0000 (15:35 -0600)]
enforce minimum Qt version in configure.

7 years agoanother swipe at fixing the xol test.
tsteven4 [Sat, 28 Apr 2018 19:27:10 +0000 (13:27 -0600)]
another swipe at fixing the xol test.

7 years agofix xol test to be compatible with msvc runtime.
tsteven4 [Sat, 28 Apr 2018 19:15:15 +0000 (13:15 -0600)]
fix xol test to be compatible with msvc runtime.

7 years agofix up rename of msvc mkspec.
tsteven4 [Sat, 28 Apr 2018 18:55:28 +0000 (12:55 -0600)]
fix up rename of msvc mkspec.

7 years agomove appveyor builds to newer versions of Qt with msvc only.
tsteven4 [Sat, 28 Apr 2018 18:36:59 +0000 (12:36 -0600)]
move appveyor builds to newer versions of Qt with msvc only.

7 years agofix up test_encoding_utf8 environment for docker.
tsteven4 [Sat, 28 Apr 2018 16:28:53 +0000 (10:28 -0600)]
fix up test_encoding_utf8 environment for docker.

7 years agoupdate reference files for compatibility with Qt >= 5.7.
tsteven4 [Sat, 28 Apr 2018 15:51:45 +0000 (09:51 -0600)]
update reference files for compatibility with Qt >= 5.7.

7 years agotest ci with new qt.
tsteven4 [Sat, 28 Apr 2018 15:36:00 +0000 (09:36 -0600)]
test ci with new qt.

7 years agoupdate configure compatibility with system zlib, (#156)
tsteven4 [Fri, 27 Apr 2018 19:38:33 +0000 (13:38 -0600)]
update configure compatibility with system zlib, (#156)

and minizip.
restore support for building with configure
outside the srcdir.

7 years agoShapefile doc and reader fixes. (#165)
tsteven4 [Thu, 26 Apr 2018 17:14:55 +0000 (11:14 -0600)]
Shapefile doc and reader fixes. (#165)

Don't cram different parts of polylines into one route, they
may not be connected.
Add documentation on transformation of coordinate systems that
may be required for GPSBabel usage of shapefiles.

7 years agoUpdate README.md
Robert Lipe [Sun, 15 Apr 2018 20:59:29 +0000 (15:59 -0500)]
Update README.md

Try to make less of a mess of English. :-)

7 years agoUpdate README.md
Robert Lipe [Sun, 15 Apr 2018 20:50:20 +0000 (15:50 -0500)]
Update README.md

make less of a mess of the markdown.

7 years agoMerge pull request #144 from gpsbabel/fix_bad_merge
Robert Lipe [Sun, 15 Apr 2018 07:41:32 +0000 (02:41 -0500)]
Merge pull request #144 from gpsbabel/fix_bad_merge

Loosen coupling of upgrade queries to OS version by using newer (2014) Qt services.

7 years agoupdate README.md
Robert Lipe [Sun, 15 Apr 2018 07:37:31 +0000 (02:37 -0500)]
update README.md

typo fixes before bedtime...

7 years agoImprovements in README.me w/ new links
Robert Lipe [Sun, 15 Apr 2018 07:28:55 +0000 (02:28 -0500)]
Improvements in README.me w/ new links

7 years agoUpdate toplevel README.md.
Robert Lipe [Sun, 15 Apr 2018 07:21:25 +0000 (02:21 -0500)]
Update toplevel README.md.

 include badges for build status, remove code.google.com reference

7 years agoMerge pull request #135 from gpsbabel/gopal
Robert Lipe [Sun, 15 Apr 2018 06:10:23 +0000 (01:10 -0500)]
Merge pull request #135 from gpsbabel/gopal

Code cleanups in gopal.

7 years agoMerge branch 'master' into gopal
Robert Lipe [Sun, 15 Apr 2018 06:09:49 +0000 (01:09 -0500)]
Merge branch 'master' into gopal

7 years agoMerge pull request #163 from tormet/master
Robert Lipe [Sun, 15 Apr 2018 05:24:11 +0000 (00:24 -0500)]
Merge pull request #163 from tormet/master

Torsten Metzner ads support for FIT version 2.0.